Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toolchain update #290

Merged
merged 8 commits into from
Nov 23, 2021
Merged

toolchain update #290

merged 8 commits into from
Nov 23, 2021

Commits on Nov 23, 2021

  1. topology: memory: allow encode/decode cycle (jaypipes#283) 

    After we fixed jaypipes#275 (allow marshal/unmarshal cycle for block.Info),
we discovered few more occourrences which also prevented
full JSON encode/decode/encode cycles (aka roundtrips).

All of the new findings still see unnecessary limitations,
so this patch adds the missing functions.

Fixes: jaypipes#283
Signed-off-by: Francesco Romani <fromani@redhat.com>
    @ffromani
    ffromani committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    f451ada View commit details
    Browse the repository at this point in the history

  2. ci; gh actions: remove golang 1.14 

    Let's begin the toolchain rotation by removing golang 1.14
from the supported set. It's just too old nowadays (november 2021).

Signed-off-by: Francesco Romani <fromani@redhat.com>
    @ffromani
    ffromani committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    9dc11a8 View commit details
    Browse the repository at this point in the history

  3. go.mod: bump module to 1.15 

    The minimum version of golang we recommend and test in CI is 1.15 anyway.

Signed-off-by: Francesco Romani <fromani@redhat.com>
    @ffromani
    ffromani committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    c4f0797 View commit details
    Browse the repository at this point in the history

  4. gofmt: tree: pass with golang 1.17 

    This PR implements the changes automatically done using
```
gofmt -s -w .
```

Signed-off-by: Francesco Romani <fromani@redhat.com>
    @ffromani
    ffromani committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    56ae4f9 View commit details
    Browse the repository at this point in the history

  5. gh actions: move the format check to golang 1.17 

    Signed-off-by: Francesco Romani <fromani@redhat.com>
    @ffromani
    ffromani committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    73875bb View commit details
    Browse the repository at this point in the history

  6. test: remove stale test 

    Remove generic test that needs to be moved in the os-specific
test until the tier-2 platform (mac, win) catch up with the
implementation.

These tests are meant to be in the linux-specific test from
the beginning, they seem to have sneaked in the generic codebase
due to a rebase glitch.

Signed-off-by: Francesco Romani <fromani@redhat.com>
    @ffromani
    ffromani committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    1413194 View commit details
    Browse the repository at this point in the history

  7. ci: gh actions: add golang 1.17 

    Add golang 1.17 to our supported matrix.

Signed-off-by: Francesco Romani <fromani@redhat.com>
    @ffromani
    ffromani committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    6a8385d View commit details
    Browse the repository at this point in the history

  8. ci: gh actions: bump golang on mac to 1.16 

    We used golang 1.15 on mac only because it
was the latest version available.

Signed-off-by: Francesco Romani <fromani@redhat.com>
    @ffromani
    ffromani committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    e90cb81 View commit details
    Browse the repository at this point in the history