Skip to content

Commit

Permalink
[Mosaic TPU] Lock down local DMAs with an SMEM source buffer temporarily
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 678616118
  • Loading branch information
apaszke authored and Google-ML-Automation committed Sep 25, 2024
1 parent a43c7f2 commit 4e3de3a
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions jaxlib/mosaic/dialect/tpu/tpu_ops.cc
Original file line number Diff line number Diff line change
Expand Up @@ -562,6 +562,13 @@ LogicalResult EnqueueDMAOp::verify() {
"device_id or core_id is specified");
}
}
// TODO(b/369517284): Add proper support for local SMEM DMAs.
auto src_memory_space = dyn_cast_if_present<tpu::MemorySpaceAttr>(
getSource().getType().getMemorySpace());
if (src_memory_space &&
src_memory_space.getValue() == tpu::MemorySpace::smem) {
return emitOpError("DMAs with an SMEM source are not fully supported");
}
return success();
}

Expand Down

0 comments on commit 4e3de3a

Please sign in to comment.