Skip to content

Commit

Permalink
fix: Allow to refresh feeds if user isn't verified (FreshRSS#2694)
Browse files Browse the repository at this point in the history
While I was looking at the number of articles of my users, I discovered
some of them had none, while having a bunch of feeds though. I took a
look at the logs generated by `app/actualize_script.php` and discovered
that the script stopped strangely (in this example, "OK" for denise is
expected, and more users too):

```
FreshRSS[1681]: FreshRSS Start feeds actualization...
Starting feed actualization at 2019-11-29T16:37:19+00:00
Actualize alice...
Actualize denise...
Results:
alice OK
denise
```

After digging a bit, I quickly realized the script stopped always on
users who didn't validate their emails. And indeed, we trigger a
`Minz_Request::forward(..., true)` for these users, in the `FreshRSS`
class. This function calls the `exit` function, which stops the script.

This patch only allows the feed#actualize action to be executed for
unverified users in order to avoid an early-`exit`. This is a quick-win
solution, but I don't think it's a good one on the long term. I'll
propose an alternative in another patch, later.
  • Loading branch information
marienfressinaud authored and Alkarex committed Dec 3, 2019
1 parent f50f676 commit f6ff656
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions app/FreshRSS.php
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ private static function checkEmailValidated() {
Minz_Request::is('user', 'profile') ||
Minz_Request::is('user', 'delete') ||
Minz_Request::is('auth', 'logout') ||
Minz_Request::is('feed', 'actualize') ||
Minz_Request::is('javascript', 'nonce')
);
if ($email_not_verified && !$action_is_allowed) {
Expand Down

0 comments on commit f6ff656

Please sign in to comment.