fix: Allow to refresh feeds if user isn't verified #2694
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was looking at the number of articles of my users, I discovered
some of them had none, while having a bunch of feeds though. I took a
look at the logs generated by
app/actualize_script.php
and discoveredthat the script stopped strangely (in this example, "OK" for denise is
expected, and more users too):
After digging a bit, I quickly realized the script stopped always on
users who didn't validate their emails. And indeed, we trigger a
Minz_Request::forward(..., true)
for these users, in theFreshRSS
class. This function calls the
exit
function, which stops the script.This patch only allows the feed#actualize action to be executed for
unverified users in order to avoid an early-
exit
. This is a quick-winsolution, but I don't think it's a good one on the long term. I'll
propose an alternative in another patch, later.