Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1724 random min max 과제 번역11번째줄 #1727

Merged
merged 1 commit into from
Dec 1, 2023
Merged

#1724 random min max 과제 번역11번째줄 #1727

merged 1 commit into from
Dec 1, 2023

Conversation

ArtistGodGun
Copy link
Contributor

@ArtistGodGun ArtistGodGun commented Dec 1, 2023 •
edited
Loading

요약

연관 이슈

#1724

Pull Request 체크리스트

TODO

  • 번역 규칙을 확인하셨나요?
    • 줄 바꿈과 단락을 '원문과 동일하게' 유지하셨나요?
    • 맞춤법 검사기로 맞춤법을 확인하셨나요?
    • 마크다운 문법에 사용되는 공백(스페이스), 큰따옴표("), 작은따옴표('), 대시(-), 백틱(`) 등의 특수문자는 그대로 두셨나요?
  • 로컬 서버 세팅 후 최종 결과물을 확인해 보셨나요?
  • PR 하나엔 번역문 하나만 넣으셨나요?
  • 의미 있는 커밋 메시지를 작성하셨나요?
    • 예시
      • [프락시] 번역
      • [프락시] 과제 번역
      • [if문과 조건부 연산자 '?'] 리뷰
      • [주석] 2차 리뷰
      • [Date 객체와 날짜] 번역

@javascript-translate-bot javascript-translate-bot requested a review from a team December 1, 2023 07:14
@CLAassistant
Copy link

CLAassistant commented Dec 1, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ArtistGodGun ArtistGodGun reopened this Dec 1, 2023
Violet-Bora-Lee
Violet-Bora-Lee approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@Violet-Bora-Lee Violet-Bora-Lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
(Looks Good To Me)

@Violet-Bora-Lee Violet-Bora-Lee merged commit 7230399 into javascript-tutorial:master Dec 1, 2023
1 check passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Violet-Bora-Lee Violet-Bora-Lee Violet-Bora-Lee approved these changes

@jihwooon jihwooon jihwooon approved these changes

@matty255 matty255 matty255 approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ArtistGodGun @CLAassistant @Violet-Bora-Lee @jihwooon @matty255 @javascript-translate-bot