Update model_utils.py #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into an issue where save_layer in model_utils.py is giving me an error that: AttributeError: 'Dense' object has no attribute 'output_shape' I found that layer.output.shape works, but isn't always a tuple, which runs afoul of the JSON encoder. So I added check for that too. I modified the code and it seems to work on Macos, Linux, Windows. I've included my debugging print statements so you can see what I was looking at.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=======================================
Coverage 95.70% 95.70%
=======================================
Files 58 58
Lines 3892 3892
=======================================
Hits 3725 3725
Misses 167 167 ☔ View full report in Codecov by Sentry. |
|
Looks good on my end! Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue where save_layer in model_utils.py is giving me an error that: AttributeError: 'Dense' object has no attribute 'output_shape'
I found that layer.output.shape works, but isn't always a tuple, which runs afoul of the JSON encoder. So I added check for that too.
I modified the code and it seems to work on Macos, Linux, Windows. I've included my debugging print statements so you can see what I was looking at.