Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Implement API only option in template #786

Closed

Conversation

Lanz86
Copy link
Contributor

@Lanz86 Lanz86 commented Jan 29, 2023

API only template version #776
implemented flag apiOnly

the command created solution with Angular

dotnet new ca-sln

Create solution without Angular

dotnet new ca-sln --apiOnly=true

@Lanz86 Lanz86 closed this Feb 20, 2023
@Lanz86 Lanz86 reopened this Feb 20, 2023
@JohanHeyvaert
Copy link

I suppose the nswag typescript client generation needs to be deactivated too. (if not already done)

@Lanz86
Copy link
Contributor Author

Lanz86 commented Feb 22, 2023

I suppose the nswag typescript client generation needs to be deactivated too. (if not already done)
Yes is implemented you find directive in src/WebUI/nswag.json line 63 - 128

dotnet new ca-sln --apiOnly=true create solution without Angular
@jasontaylordev
Copy link
Owner

@Lanz86 thank you for the contribution. The updated template supports both Angular and React, but not API only. I think we are now in a good position to implement API only too. The approach will need to change. If you look at the new template.json you can see the following parameter:

    "clientFramework": {
      "type": "parameter",
      "datatype": "choice",
      "choices": [
        {
          "choice": "angular",
          "description": "Use Angular"
        },
        {
          "choice": "react",
          "description": "Use React"
        }
      ],
      "defaultValue": "angular",
      "description": "The type of client framework to use"
    },

I think API only can be implemented by adding the choice none, for example:

        {
          "choice": "none",
          "description": "Use API only"
        },

What do you think? Do you want to tackle this change?

@jasontaylordev jasontaylordev changed the title #776 implemented apiOnly flag in template ✨ Implement API only option in template Jun 29, 2023
@Lanz86
Copy link
Contributor Author

Lanz86 commented Jun 29, 2023

Ok @jasontaylordev sounds good.
I will take care of it.

@Lanz86 Lanz86 closed this Jul 1, 2023
@Lanz86 Lanz86 reopened this Jul 1, 2023
@Lanz86 Lanz86 closed this Jul 1, 2023
@Lanz86 Lanz86 mentioned this pull request Jul 1, 2023
@Lanz86
Copy link
Contributor Author

Lanz86 commented Jul 1, 2023

Closed this PR and created new to support a none choice in clientFramework symbols #886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants