Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3948 - Changing state was also causing change of initial value #3949

Merged
merged 5 commits into from
Apr 10, 2024

Conversation

DeveloperRaj
Copy link
Contributor

Resolves Issue #3948

This addresses the problem of the dirty field not updating when the value of a nested object changes. The root cause of this issue is that the initialValues coming from props were directly assigned to the useRef, which did not perform a deep copy. Without a deep copy, it was modifying the original initialValues props along with the current state. Consequently, when comparing them for equality, the result was true

Copy link

changeset-bot bot commented Jan 30, 2024

🦋 Changeset detected

Latest commit: 8434aae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
formik Patch
formik-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formik-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2024 5:56pm

Copy link

codesandbox-ci bot commented Jan 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@quantizor
Copy link
Collaborator

@DeveloperRaj thank you, last thing can you add a unit test that verifies the initialValues object is not modified?

@DeveloperRaj
Copy link
Contributor Author

@DeveloperRaj thank you, last thing can you add a unit test that verifies the initialValues object is not modified?

@quantizor Thanks for suggestion of test. I have added a new test that checks that initial values are not being modified when we do handleChange or setValues etc. It looks a bit messy but had no option since this bug would repro only happen when we have deeply nested objects otherwise it would work just fine even without my code change.

Copy link
Collaborator

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit f57ca9b into jaredpalmer:main Apr 10, 2024
9 checks passed
@github-actions github-actions bot mentioned this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants