Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fixed resetForm function dependency issue #3872

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

rajpatelbot
Copy link
Contributor

@rajpatelbot rajpatelbot commented Aug 31, 2023

Closes: #3861

As i mentioned in the issue section that the unexpected behaviour is comming while using resetForm function due to missing dependency. Here is the fix.

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2023

⚠️ No Changeset found

Latest commit: 1aeaad4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formik-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2023 8:19pm

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1aeaad4:

Sandbox Source
Formik TypeScript Playground (forked) Configuration

Copy link
Collaborator

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense ty

@rajpatelbot rajpatelbot changed the title FIX: Fixed onReset function dependency issue FIX: Fixed resetForm function dependency issue Aug 31, 2023
@kodiakhq kodiakhq bot merged commit 5c01ee7 into jaredpalmer:main Aug 31, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing props.onReset dependency in useCallback of resetForm function.
2 participants