Fix TreeMaker Protocol, removing almost all # type: ignore
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
Fix-TreeMaker-Protocol
branch
3 times, most recently
from
59d5934
to
97f182f
Compare
Avasam
force-pushed
the
Fix-TreeMaker-Protocol
branch
from
97f182f
to
a4f8fc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither
pathlib.PathnotRecordingwere validTreeMakerprotocols.objectreturn type is so that any return type will match. It essentially means the return value is unused. (_typeshed.Unusedcan be used for that semantic if you'd prefer over a bareobject)# pragma: no coverremoved because single line...are excluded by coverage by default and our configs exclude ProtocolsNo piece of code validated that
Recordingwas a validTreeMakerstatically. As long as mypy runs on tests this is now validated.The last
# type: ignoreleft is caused by singledispatch. It's fixable using a "dummy" main method. But I figured you'd prefer staying concise with a suppression comment (it would also be out of scope of this PR to change that)Relates to jaraco/skeleton#143