options.logo support string array #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlhopf
changed the title
andy128k
requested changes
Oct 12, 2022
There was a problem hiding this comment.
Great work!
My only concern is that only first file's hash is used for caching. Cache invalidation is known to be a hard thing ;).
May you check if this change #334 can be useful here?
src/index.js
Outdated
| // Recompile filesystem cache if any source based path change: | ||
| (fileSources) => | ||
| getRelativeOutputPath( | ||
| fileSources[0].hash, |
There was a problem hiding this comment.
Better to hash all files.
There was a problem hiding this comment.
Smth like getContentHash(...fileSources.map(s => s.content)) should work.
src/index.js
Outdated
| const resolvedPublicPath = getResolvedPublicPath( | ||
| logo.hash, | ||
| logoFileSources[0].hash, |
favicons >= 7.0.0 picks source image by it's size, solves jantimon#265
carlhopf
force-pushed
the
logo-string-array
branch
3 times, most recently
from
9f781aa
to
c3aeb7d
Compare
|
thanks the review 👍 let me know if the changes work, and i'll go ahead and update/rebase the maskable pr |
carlhopf
force-pushed
the
logo-string-array
branch
from
c3aeb7d
to
fd86520
Compare
|
ah took me a bit to wrap my head around the internals ;) thanks for the example 👍 updated commit pushed |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
favicons >= 7.0.0 picks source image by it's size if provided with an array
solves #265