Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya! I've run across this one a few times using this, there's a race condition in the stop method that can cause unrender to throw an exception.
I see there's two failing tests in this PR, but they are failing on master as well.
to be killed.
@current_frame after line 1 of Whirly.unrender, causing
a nil to be passed to Unicode::DisplayWidth.of, and causing
an exception as a result.
finish before proceeding, otherwise we risk memory corruption.