Merge pull request Expensify#31527 from dukenv0307/fix/31446

Disable complete task for anonymous user
janicduplessis · Nov 21, 2023 · da549c0 · da549c0
2 parents 360fe05 + 18be80e
commit da549c0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/components/TaskHeaderActionButton.js b/src/components/TaskHeaderActionButton.js
@@ -6,6 +6,7 @@ import compose from '@libs/compose';
 import * as ReportUtils from '@libs/ReportUtils';
 import reportPropTypes from '@pages/reportPropTypes';
 import useThemeStyles from '@styles/useThemeStyles';
+import * as Session from '@userActions/Session';
 import * as Task from '@userActions/Task';
 import ONYXKEYS from '@src/ONYXKEYS';
 import Button from './Button';
@@ -38,7 +39,7 @@ function TaskHeaderActionButton(props) {
                 isDisabled={!Task.canModifyTask(props.report, props.session.accountID)}
                 medium
                 text={props.translate(ReportUtils.isCompletedTaskReport(props.report) ? 'task.markAsIncomplete' : 'task.markAsComplete')}
-                onPress={() => (ReportUtils.isCompletedTaskReport(props.report) ? Task.reopenTask(props.report) : Task.completeTask(props.report))}
+                onPress={Session.checkIfActionIsAllowed(() => (ReportUtils.isCompletedTaskReport(props.report) ? Task.reopenTask(props.report) : Task.completeTask(props.report)))}
                 style={[styles.flex1]}
             />
         </View>

diff --git a/src/libs/actions/ReportActions.ts b/src/libs/actions/ReportActions.ts
@@ -27,7 +27,7 @@ function clearReportActionErrors(reportID: string, reportAction: ReportAction) {
 
         // Delete the failed task report too
         const taskReportID = reportAction.message?.[0]?.taskReportID;
-        if (taskReportID) {
+        if (taskReportID && ReportActionUtils.isCreatedTaskReportAction(reportAction)) {
             Report.deleteReport(taskReportID);
         }
         return;