Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cortex engines init api with empty body should init default options #962

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix: cortex engines init api with empty body should init default options #962

merged 1 commit into from
Aug 1, 2024

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

  • Fixed an issue where client sends empty body should also provide best default engine init options

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan merged commit 4b6523c into dev Aug 1, 2024
1 check passed
@louis-jan louis-jan deleted the fix/cortex-init-api-empty-param-should-use-default-options branch August 1, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marknguyen1302 marknguyen1302 marknguyen1302 approved these changes

@namchuai namchuai Awaiting requested review from namchuai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-jan @marknguyen1302