Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: watch models and engines update for proper data retrieval #960

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Aug 1, 2024

Describe Your Changes

  • Fixed an issue where models and engines are not being updated properly as soon as users manually modify model.yaml

Models list before and after manipulated
Screenshot 2024-08-01 at 14 24 22

llamacpp engine is ready before deleting manually
Screenshot 2024-08-01 at 14 23 26

The status is updated as soon as users deleted engine files
Screenshot 2024-08-01 at 14 23 59

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan force-pushed the feat/watch-models-engines-update branch 2 times, most recently from 2e07fd5 to 057f28c Compare August 1, 2024 07:25
@Van-QA Van-QA force-pushed the feat/watch-models-engines-update branch from 057f28c to 40561aa Compare August 1, 2024 07:29
@louis-jan louis-jan force-pushed the feat/watch-models-engines-update branch from 40561aa to c365ff1 Compare August 1, 2024 07:40
@marknguyen1302 marknguyen1302 merged commit 9d011e3 into dev Aug 1, 2024
1 check passed
@marknguyen1302 marknguyen1302 deleted the feat/watch-models-engines-update branch August 1, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: watch data folder and update the running server accordingly
2 participants