Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix winget PR issue #934

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Fix winget PR issue #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/cortex-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,14 @@ jobs:
name: Code Signing Windows
if: runner.os == 'Windows'

- name: Update version in installer.iss using sed
if: runner.os == 'Windows'
shell: bash
run: |
cd cortex-js
sed -i "s/AppVersion=1.0/AppVersion=${{ needs.create-draft-release.outputs.version }}/g" installer.iss
cat installer.iss

- name: Compile .ISS to .EXE Installer
uses: Minionguyjpro/Inno-Setup-Action@v1.2.2
if: runner.os == 'Windows'
Expand Down
14 changes: 7 additions & 7 deletions cortex-js/installer.iss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
; Inno Setup Script
; Define the application name, version, and other details
[Setup]
AppName=Cortex
AppName=Cortexso
AppVersion=1.0
DefaultDirName={pf}\Cortex
DefaultGroupName=Cortex
DefaultDirName={pf}\Cortexso
DefaultGroupName=Cortexso
OutputDir=.
OutputBaseFilename=setup
Compression=lzma
Expand All @@ -21,12 +21,12 @@ Source: "cortex.exe"; DestDir: "{app}"; Flags: ignoreversion

; Define the icons to be created
[Icons]
Name: "{group}\Cortex"; Filename: "{app}\cortex.exe"
Name: "{group}\Cortexso"; Filename: "{app}\cortex.exe"

; Define the run section to execute the application after installation
[Run]
Filename: "cmd"; Parameters: "/c setx PATH ""%PATH%;{app}"""; StatusMsg: "Updating system PATH environment variable..."; Flags: runhidden
Filename: "{app}\cortex.exe"; Description: "{cm:LaunchProgram,Cortex}"; Flags: nowait postinstall skipifsilent
Filename: "{app}\cortex.exe"; Description: "{cm:LaunchProgram,Cortexso}"; Flags: nowait postinstall skipifsilent

; Define the tasks section (optional, for additional tasks like creating desktop icons)
[Tasks]
Expand All @@ -35,5 +35,5 @@ Name: "quicklaunchicon"; Description: "Create a &Quick Launch icon"; GroupDescri

; Define icons for the additional tasks
[Icons]
Name: "{commondesktop}\Cortex"; Filename: "{app}\cortex.exe"; Tasks: desktopicon
Name: "{userappdata}\Microsoft\Internet Explorer\Quick Launch\Cortex"; Filename: "{app}\cortex.exe"; Tasks: quicklaunchicon
Name: "{commondesktop}\Cortexso"; Filename: "{app}\cortex.exe"; Tasks: desktopicon
Name: "{userappdata}\Microsoft\Internet Explorer\Quick Launch\Cortexso"; Filename: "{app}\cortex.exe"; Tasks: quicklaunchicon
Loading