Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the api desc #933

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Update the api desc #933

merged 2 commits into from
Jul 29, 2024

Conversation

irfanpena
Copy link
Contributor

Describe Your Changes

  • Update the API desc
  • Remove the unused API tags

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@irfanpena irfanpena requested a review from louis-jan July 29, 2024 06:17
@irfanpena irfanpena self-assigned this Jul 29, 2024
louis-jan
louis-jan reviewed Jul 29, 2024
View reviewed changes
cortex-js/src/app.ts Outdated Show resolved Hide resolved
louis-jan
louis-jan approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @irfanpena

@louis-jan louis-jan merged commit 82c2b55 into dev Jul 29, 2024
2 checks passed
@louis-jan louis-jan deleted the update-api branch July 29, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@irfanpena irfanpena

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irfanpena @louis-jan