Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update default api server config #921

Merged
merged 6 commits into from
Jul 26, 2024
Merged

chore: update default api server config #921

merged 6 commits into from
Jul 26, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Jul 26, 2024 •
edited
Loading

Describe Your Changes

  • There is no default API server configs provided
  • Should not initialize cortexjs instance root command

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan force-pushed the chore/update-default-cortex-js-server-configs branch from 54b8b5d to 0496732 Compare July 26, 2024 04:56
@louis-jan louis-jan force-pushed the chore/update-default-cortex-js-server-configs branch from 0496732 to 2fbf1df Compare July 26, 2024 05:11
@louis-jan louis-jan merged commit 7683f5f into dev Jul 26, 2024
2 checks passed
@louis-jan louis-jan deleted the chore/update-default-cortex-js-server-configs branch July 26, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marknguyen1302 marknguyen1302 marknguyen1302 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-jan @marknguyen1302