fix: nightly updater #1202
Merged
fix: nightly updater #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vansangpfiev
commented
Sep 12, 2024
engine/commands/cortex_upd_cmd.h
Outdated
| @@ -83,7 +85,8 @@ inline bool ReplaceBinaryInflight(const std::filesystem::path& src, | |||
| // Already has the newest | |||
| return true; | |||
| } | |||
| std::filesystem::path temp = std::filesystem::temp_directory_path() / "cortex_temp"; | |||
| std::filesystem::path temp = | |||
| file_manager_utils::GetExecutableFolderContainerPath() / "cortex_temp"; | |||
There was a problem hiding this comment.
Should rename in the same folder
vansangpfiev
commented
Sep 12, 2024
| @@ -133,6 +133,17 @@ void ForkProcess() { | |||
| int main(int argc, char* argv[]) { | |||
| { file_manager_utils::CreateConfigFileIfNotExist(); } | |||
|
|
|||
| // Delete temporary file if it exists | |||
| auto temp = | |||
| file_manager_utils::GetExecutableFolderContainerPath() / "cortex_temp"; | |||
There was a problem hiding this comment.
After cortex update, we can only remove temporary file at the next start
vansangpfiev
commented
Sep 12, 2024
| @@ -230,7 +230,7 @@ inline std::filesystem::path GetContainerFolderPath( | |||
| } else if (type == "CudaToolkit") { | |||
| container_folder_path = current_path; | |||
| } else if (type == "Cortex") { | |||
| container_folder_path = current_path / "cortex"; | |||
| container_folder_path = std::filesystem::temp_directory_path() / "cortex"; | |||
There was a problem hiding this comment.
Download binary to temp folder
vansangpfiev
commented
Sep 12, 2024
| @@ -190,7 +190,8 @@ bool CortexUpdCmd::GetNightly(const std::string& v) { | |||
|
|
|||
| // Replace binay file | |||
| auto executable_path = file_manager_utils::GetExecutableFolderContainerPath(); | |||
| auto src = executable_path / "cortex" / GetCortexBinary(); | |||
| auto src = std::filesystem::temp_directory_path() / "cortex" / kCortexBinary / | |||
There was a problem hiding this comment.
Change accordingly to s3 structure
vansangpfiev
requested review from
dan-homebrew,
namchuai and
nguyenhoangthuan99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
cortex update, we rename it tocortex_tempthen need to delete at the next start.Fixes Issues
Self Checklist