Fix: create log folder before logging #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhoangthuan99
changed the title
nguyenhoangthuan99
requested review from
dan-homebrew,
vansangpfiev and
namchuai
namchuai
reviewed
Sep 12, 2024
engine/main.cc
Outdated
| @@ -31,6 +31,7 @@ void RunServer() { | |||
| << " Port: " << config.apiServerPort << "\n"; | |||
|
|
|||
| // Create logs/ folder and setup log to file | |||
| std::filesystem::create_directory(config.logFolderPath); | |||
There was a problem hiding this comment.
using std::filesystem::create_directories should be better. Seems like it handle create directory recursively.
https://en.cppreference.com/w/cpp/filesystem/create_directory
Also, I'm worry about concatenate path using / might not work on windows. Should using std::filesystem::path
…janhq/cortex.cpp into fix/create-log-folder-if-didn't-existed
dan-homebrew
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
@nguyenhoangthuan99 Approved to unblock. However:
- Please add tests!
- This is the sort of thing that an intern will not realize, remove folder creation, and end up bricking the entire product
namchuai
reviewed
Sep 12, 2024
namchuai
approved these changes
Sep 12, 2024
vansangpfiev
approved these changes
Sep 13, 2024
nguyenhoangthuan99
deleted the
fix/create-log-folder-if-didn't-existed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1198
Summary changes: