Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update .cortexrc fields #1172

Merged
merged 1 commit into from
Sep 9, 2024
Merged

chore: update .cortexrc fields #1172

merged 1 commit into from
Sep 9, 2024

Conversation

namchuai
Copy link
Contributor

@namchuai namchuai commented Sep 9, 2024

Describe Your Changes

  • Update the fields from
    host -> apiServerHost
    port -> apiServerPort
    Previously I mistakenly put it as host and port

Screenshot

Screenshot 2024-09-09 at 10 18 42

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@dan-homebrew dan-homebrew changed the title chore: update cortexrc fields chore: update .cortexrc fields Sep 9, 2024
@dan-homebrew
Copy link
Contributor

@namchuai @vansangpfiev Given the amount of port number collisions at 4 digits, should we consider a standard port for Cortex that is higher rank?

  • 267839 = Cortex in T9

Outside of that: how did we choose 3928?

Copy link
Contributor

@dan-homebrew dan-homebrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dan-homebrew
Copy link
Contributor

dan-homebrew commented Sep 9, 2024

@namchuai Out of curiosity, what was the issue with the initial port and host varnames?

  • I'm not sure if it's an improvement to make it more verbose
  • Given that cortex.cpp only has a single port/host now (vs. cortex platform in the original issue)

@namchuai
Copy link
Contributor Author

namchuai commented Sep 9, 2024

@namchuai Out of curiosity, what was the issue with the initial port and host varnames?

  • I'm not sure if it's an improvement to make it more verbose
  • Given that cortex.cpp only has a single port/host now (vs. cortex platform in the original issue)

One of the reason is I want to make it compatible with what user currently have. Some user already installed cortex (cortexjs) and they already have .cortexrc

@namchuai namchuai merged commit d31c7a9 into dev Sep 9, 2024
4 checks passed
@namchuai namchuai deleted the j/update-cortexrc-fields branch September 9, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants