Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update engine install/uninstall CLI commands #1171

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: update engine install/uninstall CLI commands #1171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions engine/controllers/command_line_parser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
#include "config/yaml_config.h"
#include "httplib.h"
#include "services/engine_service.h"
#include "utils/cortex_utils.h"
#include "utils/file_manager_utils.h"
#include "utils/logging_utils.h"

Expand Down Expand Up @@ -135,9 +134,19 @@ bool CommandLineParser::SetupCommand(int argc, char** argv) {
command.Exec();
});

auto install_cmd = engines_cmd->add_subcommand("install", "Install engine");
install_cmd->callback([] { CLI_LOG("Engine name can't be empty!"); });
for (auto& engine : engine_service_.kSupportEngines) {
std::string engine_name{engine};
EngineManagement(engines_cmd, engine_name, version);
EngineInstall(install_cmd, engine_name, version);
}

auto uninstall_cmd =
engines_cmd->add_subcommand("uninstall", "Uninstall engine");
uninstall_cmd->callback([] { CLI_LOG("Engine name can't be empty!"); });
for (auto& engine : engine_service_.kSupportEngines) {
std::string engine_name{engine};
EngineUninstall(uninstall_cmd, engine_name);
}

EngineGet(engines_cmd);
Expand Down Expand Up @@ -227,25 +236,22 @@ bool CommandLineParser::SetupCommand(int argc, char** argv) {
return true;
}

void CommandLineParser::EngineManagement(CLI::App* parent,
const std::string& engine_name,
std::string& version) {
auto engine_cmd =
parent->add_subcommand(engine_name, "Manage " + engine_name + " engine");
void CommandLineParser::EngineInstall(CLI::App* parent,
const std::string& engine_name,
std::string& version) {
auto install_engine_cmd = parent->add_subcommand(engine_name, "");

auto install_cmd = engine_cmd->add_subcommand(
"install", "Install " + engine_name + " engine");
install_cmd->add_option("-v, --version", version,
"Engine version. Default will be latest");

install_cmd->callback([engine_name, &version] {
install_engine_cmd->callback([&] {
commands::EngineInitCmd eic(engine_name, version);
eic.Exec();
});
}

void CommandLineParser::EngineUninstall(CLI::App* parent,
const std::string& engine_name) {
auto uninstall_engine_cmd = parent->add_subcommand(engine_name, "");

auto uninstall_desc{"Uninstall " + engine_name + " engine"};
auto uninstall_cmd = engine_cmd->add_subcommand("uninstall", uninstall_desc);
uninstall_cmd->callback([engine_name] {
uninstall_engine_cmd->callback([&] {
commands::EngineUninstallCmd cmd(engine_name);
cmd.Exec();
});
Expand Down
6 changes: 4 additions & 2 deletions engine/controllers/command_line_parser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@ class CommandLineParser {
bool SetupCommand(int argc, char** argv);

private:
void EngineManagement(CLI::App* parent, const std::string& engine_name,
std::string& version);
void EngineInstall(CLI::App* parent, const std::string& engine_name,
std::string& version);

void EngineUninstall(CLI::App* parent, const std::string& engine_name);

void EngineGet(CLI::App* parent);

Expand Down
Loading