Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cortex update command #1095

Merged
merged 8 commits into from
Sep 6, 2024
Merged

feat: cortex update command #1095

merged 8 commits into from
Sep 6, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Sep 4, 2024 •
edited
Loading

#1087
Only support to download latest version for now
Also added cortex -v command
#1066

.\cortex.exe -v
v0.5.0

@vansangpfiev vansangpfiev marked this pull request as ready for review September 5, 2024 09:14
@namchuai
Copy link
Contributor

namchuai commented Sep 5, 2024

Nice one! I have one question. What happen in windows, if the server is running, then our executable will be in used, right? ? will std::rename fail and failed the update, I think?

namchuai
namchuai approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looks good. Just some small nits. Not required though.

@vansangpfiev
Copy link
Contributor Author

vansangpfiev commented Sep 6, 2024 •
edited
Loading

Nice one! I have one question. What happen in windows, if the server is running, then our executable will be in used, right? ? will std::rename fail and failed the update, I think?

We cannot replace but can remove file on windows if it is in used.
Also added a TODO to stop server if it is running before updating.

@vansangpfiev vansangpfiev merged commit 390111c into dev Sep 6, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the feat/cortex-update-cmd branch September 6, 2024 03:50
@dan-homebrew
Copy link
Contributor

I am removing this from Project Board:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 nguyenhoangthuan99 approved these changes

Assignees
No one assigned
Labels
category: app shell
Projects
Jan & cortex.cpp
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vansangpfiev @namchuai @dan-homebrew @nguyenhoangthuan99