Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle stop server #1048

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix: handle stop server #1048

merged 1 commit into from
Aug 29, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Aug 29, 2024 •
edited
Loading

http connection closes when we send stop to server

.\cortex-cpp.exe stop
20240829 08:20:13.669000 UTC 6056 WARN  HTTP error: Failed to read connection - stop_server_cmd.cc:16

should do it better

.\cortex-cpp.exe stop
20240829 08:31:55.266000 UTC 12584 INFO  {"message":"Program is exitting, goodbye!"} - stop_server_cmd.cc:13

@vansangpfiev vansangpfiev self-assigned this Aug 29, 2024
@vansangpfiev vansangpfiev merged commit 8fdff72 into feat/cortex-engine Aug 29, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/stop-server branch August 29, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 nguyenhoangthuan99 approved these changes

Assignees

@vansangpfiev vansangpfiev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vansangpfiev @namchuai @nguyenhoangthuan99