Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: chat command #1032

Merged
merged 1 commit into from
Aug 28, 2024
Merged

feat: chat command #1032

merged 1 commit into from
Aug 28, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Aug 27, 2024 •
edited
Loading

Describe Your Changes

#32
Support for chat command:

  • -m, --message option
  • check model is loaded before starting
  • exit() to terminate conversation

TODO: handle signal for SIGINT

@vansangpfiev vansangpfiev marked this pull request as ready for review August 28, 2024 01:24
namchuai
namchuai approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vansangpfiev vansangpfiev merged commit 95f7d67 into feat/cortex-engine Aug 28, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the feat/chat-command branch August 28, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 nguyenhoangthuan99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vansangpfiev @namchuai @nguyenhoangthuan99