Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: engine init is broken #1022

Merged
merged 1 commit into from
Aug 16, 2024
Merged

fix: engine init is broken #1022

merged 1 commit into from
Aug 16, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Aug 16, 2024

Describe Your Changes

  • Fixed an issue where cortex looks for a wrong binary name to download. The engines got different release names. E.g. noavx on llama.cpp but not for others. Platform for both llama.cpp and tensorrt-llm but not onnx.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan merged commit 337de1e into dev Aug 16, 2024
1 check passed
@louis-jan louis-jan deleted the fix/engine-init-is-broken branch August 16, 2024 02:52
@imtuyethan
Copy link
Contributor

imtuyethan commented Sep 2, 2024

What are the updates for this @louis-jan i saw it was related to #1020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants