Fix winget PR issue (#934)

Co-authored-by: Hien To <tominhhien97@gmail.com>
janhq · Jul 29, 2024 · a8eb3b4 · a8eb3b4
1 parent 82c2b55
commit a8eb3b4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/.github/workflows/cortex-build.yml b/.github/workflows/cortex-build.yml
@@ -362,6 +362,14 @@ jobs:
         name: Code Signing Windows
         if: runner.os == 'Windows'
 
+      - name: Update version in installer.iss using sed
+        if: runner.os == 'Windows'
+        shell: bash
+        run: |
+          cd cortex-js
+          sed -i "s/AppVersion=1.0/AppVersion=${{ needs.create-draft-release.outputs.version }}/g" installer.iss
+          cat installer.iss
+
       - name: Compile .ISS to .EXE Installer
         uses: Minionguyjpro/Inno-Setup-Action@v1.2.2
         if: runner.os == 'Windows'

diff --git a/cortex-js/installer.iss b/cortex-js/installer.iss
@@ -1,10 +1,10 @@
 ; Inno Setup Script
 ; Define the application name, version, and other details
 [Setup]
-AppName=Cortex
+AppName=Cortexso
 AppVersion=1.0
-DefaultDirName={pf}\Cortex
-DefaultGroupName=Cortex
+DefaultDirName={pf}\Cortexso
+DefaultGroupName=Cortexso
 OutputDir=.
 OutputBaseFilename=setup
 Compression=lzma
@@ -21,12 +21,12 @@ Source: "cortex.exe"; DestDir: "{app}"; Flags: ignoreversion
 
 ; Define the icons to be created
 [Icons]
-Name: "{group}\Cortex"; Filename: "{app}\cortex.exe"
+Name: "{group}\Cortexso"; Filename: "{app}\cortex.exe"
 
 ; Define the run section to execute the application after installation
 [Run]
 Filename: "cmd"; Parameters: "/c setx PATH ""%PATH%;{app}"""; StatusMsg: "Updating system PATH environment variable..."; Flags: runhidden
-Filename: "{app}\cortex.exe"; Description: "{cm:LaunchProgram,Cortex}"; Flags: nowait postinstall skipifsilent
+Filename: "{app}\cortex.exe"; Description: "{cm:LaunchProgram,Cortexso}"; Flags: nowait postinstall skipifsilent
 
 ; Define the tasks section (optional, for additional tasks like creating desktop icons)
 [Tasks]
@@ -35,5 +35,5 @@ Name: "quicklaunchicon"; Description: "Create a &Quick Launch icon"; GroupDescri
 
 ; Define icons for the additional tasks
 [Icons]
-Name: "{commondesktop}\Cortex"; Filename: "{app}\cortex.exe"; Tasks: desktopicon
-Name: "{userappdata}\Microsoft\Internet Explorer\Quick Launch\Cortex"; Filename: "{app}\cortex.exe"; Tasks: quicklaunchicon
+Name: "{commondesktop}\Cortexso"; Filename: "{app}\cortex.exe"; Tasks: desktopicon
+Name: "{userappdata}\Microsoft\Internet Explorer\Quick Launch\Cortexso"; Filename: "{app}\cortex.exe"; Tasks: quicklaunchicon