#186 implement Jaccard similarity #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for this! I'm traveling these next few weeks so may be slow but will take a closer look and get this merged soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried my best to implement the Jaccard similarity from Issue #186. I also created a PR at jamesturk/jellyfish-testdata#9. However, I am unsure how to integrate the Git submodule changes. testdata has yet to be updated in this PR.
I was also not sure if I am still supposed to create a Python implementation. I simply added a Rust implementation for now.
Furthermore, I had to update testutils.rs to support the optional
ngram_sizeparameter.