Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target MonoAndroid 11.0 to help Android 11 to display store review. #27

Closed
wants to merge 1 commit into from

Conversation

Iguins
Copy link

@Iguins Iguins commented Jul 9, 2021

Please take a moment to fill out the following:

Fixes # .
Android 11 devices does not show up store review popup in internal channel

Changes Proposed in this pull request:

  • Target MonoAndroid 11.0 to help Android 11 to display store review.
  • Update Test's Manifest to target API level 30

@jamesmontemagno
Copy link
Owner

Compilation wont matter it is only the TargetSDK that you need to set on your own personal project.

@Iguins
Copy link
Author

Iguins commented Jul 9, 2021

That we did, but we are facing an issue only for Android 11 device.
Because it's hard to test locally I'm going to put all or investigation there.

@saamerm
Copy link
Contributor

saamerm commented Jul 9, 2021

@Iguins whats the "internal" channel that you mentioned?

Have you tried downloading the app on to that device through the android play store's "internal app sharing" feature?

Did it work?

@saamerm
Copy link
Contributor

saamerm commented Jul 9, 2021

Also, could you try to download this game and win the game once to see the popup on your android 11?

https://play.google.com/store/apps/details?id=com.tfp.numberbomb

The app uses v3.1 of this package and target SDK version 30 and target framework v11.0

@Iguins
Copy link
Author

Iguins commented Jul 9, 2021

Also, could you try to download this game and wind the game once to see the popup on your android 11?

https://play.google.com/store/apps/details?id=com.tfp.numberbomb

The app uses v3.1 of this package and target SDK version 30 and target framework v11.0

Thank you! i'm going to try that and confirm the channel.
But yeah basically it's working on android 10 device but seems not on 11 without any specific error in the logcat.

@proberge-dev
Copy link

@jamesmontemagno @saamerm
Just to make sure we're on the same page, we're talking about In-App Review.
We've put it on an internal test track (and have successfully downloaded the app from this test track) and tested on
S9 / Android 10
Galaxy S7 / Android 8
Pixel 3 XL / Android 11
etc.

@saamerm
Copy link
Contributor

saamerm commented Jul 9, 2021

@philipe-roberge yes. Did you try to see the in app review in this app on your Android 11 device? Or is it failing for all devices for you :

Also, could you try to download this game and win the game once to see the popup on your android 11?
https://play.google.com/store/apps/details?id=com.tfp.numberbomb
The app uses v3.1 of this package and target SDK version 30 and target framework v11.0

@antoine-hebert
Copy link

antoine-hebert commented Jul 9, 2021

@philipe-roberge yes. Did you try to see the in app review in this app on your Android 11 device? Or is it failing for all devices for you :

Also, could you try to download this game and win the game once to see the popup on your android 11?
https://play.google.com/store/apps/details?id=com.tfp.numberbomb
The app uses v3.1 of this package and target SDK version 30 and target framework v11.0

Hi @saamerm ,

I just tried the https://play.google.com/store/apps/details?id=com.tfp.numberbomb game and I am not seeing the in app review prompt on Android 11 (Pixel 3 XL), but it's working fine on Android 8 (Galaxy S7) device.

Did you try the https://play.google.com/store/apps/details?id=com.tfp.numberbomb on a Android 11 device?

UPDATE: Okay so I think the issue is probably not Android 11 related as we just got it working on a Pixel 5 running Android 11.

@saamerm
Copy link
Contributor

saamerm commented Jul 9, 2021

I'm glad you were able to figure it out easily. And I'm glad that app is a good and easy one to test this functionality 😆
I have tested the review on android 11 successfully as well. Perhaps you can do an 'adb logcat' and compare the logcat of the two phones to check out what's up

@saamerm
Copy link
Contributor

saamerm commented Jul 10, 2021

@Iguins did you figure out your issue?

@saamerm
Copy link
Contributor

saamerm commented Jul 15, 2021

@Iguins should we close this?

@Iguins
Copy link
Author

Iguins commented Jul 15, 2021

Unfortunately I did not put my hand on a Android 11 device to test completely . As it seems the issue was not releated
So if we are not in a hurry to increase the target I believe yes?

@danlacey
Copy link

Hello all, I am experiencing an issue with this plugin where it works fine on a Pixel 5a on Android 11, but fails to display the in app review slide up on a Pixel 4a on Android 11. Has anyone else seen a similar issue?

@saamerm
Copy link
Contributor

saamerm commented Sep 15, 2021

@danlacey did you take a look at these steps https://github.com/jamesmontemagno/StoreReviewPlugin#android ?

@danlacey
Copy link

I have looked into those situations. Here is what our release build configuration looks like:

image

image

@saamerm
Copy link
Contributor

saamerm commented Sep 15, 2021

@danlacey did you try the 1st step and the 2nd step? What does your logcat say?
Can you try to play the game mentioned, but try it with the Pixel 4a first?
Another possibility: It won't show up if you are using the same Google Play account on both devices and you have already rated the same app with one device first.

@danlacey
Copy link

danlacey commented Sep 15, 2021

I have not looked at logcat. I'll do that next. We have run the game and it shows the in app review for me (pixel 5a) but not my teammate (pixel 4a). We are using personal accounts via Internal App Sharing for our app

@saamerm
Copy link
Contributor

saamerm commented Dec 29, 2021

@danlacey any success?
@Iguins is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants