Fix TypeError thrown during install #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change solves the problem of a fatal error thrown during the execution of the post-install/update script. Specifically: ``` Fatal error: Uncaught TypeError: Composer\Downloader\DownloadManager::download(): Argument jakoch#3 ($prevPackage) must be of type ?Composer\Package\PackageInterface, bool given, called in ...\jakoch\phantomjs-installer\src\PhantomInstaller\Installer.php on line 192 and defined in .../Composer/Downloader/DownloadManager.php:182 ```
|
Hey Alex, thank you for contributing! 👍🏻 How can i trigger the error itself? |
jakoch
added a commit
that referenced
this pull request
Sep 3, 2021
Merge pull request #51 from alexstewartja/composer-fix Fix TypeError thrown during install
|
PR was merged. |
|
No problem Jens. Thanks for the quick merge! This PR fixes jonnnnyw/php-phantomjs#288, referenced by composer/composer#9698 and discussed in #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change solves the problem of a fatal error thrown during the execution of the post-install/update script. Specifically: