Add support for Piped links #1556
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a command to set the Piped instance URL. Also added Piped to the config file.
Bot will accept music commands using the user's Piped instance links.
|
Dude! O.O This is so cool! Thanks so much for the work - this is awesome! |
|
This should probably be implemented as either a source manager or a transform |
lilliepad1
added a commit
to lilliepad1/MusicBotShiverFork
that referenced
this pull request
Jul 11, 2024
Hopefully would result in better performance in different regions.
|
Sorry if this isn't where I would put this comment or if it's best suited as a new issue, but since they both have the same function, similar popularity, and open API documentation, this might be a good opportunity to also add support for Invidious links. Documentation can be found here: https://docs.invidious.io/api/ Appreciate the work you've put into this PR. |
|
New source requests should be made to lavaplayer or implemented in a standalone source manager; this is not something that JMusicBot would be providing exclusively. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request...
Description
Allows users to send Piped links to the music bot
Purpose
Users who prefer to use Piped over YouTube can send their instance's links to the bot
Relevant Issue(s)
This PR closes issue #1492