-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a MakeFile #1513
base: master
Are you sure you want to change the base?
Add a MakeFile #1513
Conversation
I have nothing against makefiles (I use them extensively in other non-java projects) but it would be helpful to have more feedback on why adding this would be useful to this project specifically.
I'm open to discussion about the merits of adding this, if you or anyone else would like to weigh in. |
My thinking was mostly this: If build instruction aren't going to be provided, it's a good enough way to indicate how to build it. Personally, I had forgotten how to build Java applications and had added this such that I wouldn't need to remember how to :-) If not a Makefile, maybe a small section on building and testing could be added to README.md instead? |
I'd rather do this than add a Makefile, although I'm still hesitant to encourage people to build the project themselves, as someone who is capable of making a pull request should already be able to open and build this project in their IDE (without any additional changes/instructions; most Java IDEs support maven), and I don't want to nor have the time to help people who run into issues trying to build it on their own. |
This pull request...
Description
Add a Makefile for building,testing or cleaning.
Purpose
Allows developers to simply run
make build
ormake test
to build or test the application. Also allows formake clean
to clean the./target
directory.Relevant Issue(s)
N/A