-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom command to launch frequently used URL #1363
Conversation
revert back to Snapshot version
You seem to have changed every file's mode/permission in the project, thus creating a diff out of every file. You also unintentionally committed binaries and other unwanted files into your branch. Please undo those, then force-push your changes into the branch. |
Hello, OK let me try to review that. However the binaries are now in the main project as part of last commit : https://github.com/jagrosh/MusicBot/tree/master/src/main/resources/natives |
Oh. I apologize, I never noticed they were added. I got confused, since every file is being shown as modified in this PR. It'd be great if all the files can be reset back to how they are in our master branch. |
We added 2 commits with the reset of permissions and the new code logic. Let me know if this is good or not :) |
I'm changing a few things for the integration to be more consistent with the rest of the project. |
# Conflicts: # src/main/java/com/jagrosh/jmusicbot/commands/music/CustomPlayCmd.java
@jagrosh, any chance this can make it to the repo? I don't mind if you don't want to, just refuse the PR so that I know :) Thanks again for the hard work ! |
This is now broken following the update on Lavacommand & so on. |
This pull request...
Description
This commands implements the custom command which allows to use the shortcuts config to run commands such as
!custom mymusic to avoid using the full URL every time.
Purpose
When using the same music multiple times, it might be useful to add it in the config for custom calls
Relevant Issue(s)
None noted