Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the description of esCleaner.py from plugin/storage/es/README.md #5891

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

chinaran
Copy link
Contributor

esCleaner.py no longer exists, but README.md still has the relevant content, so I've made some adjustments.

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro merged commit 0339b4b into jaegertracing:main Aug 27, 2024
40 of 42 checks passed
@yurishkuro
Copy link
Member

thanks

@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.46%. Comparing base (9d70957) to head (7ebcfa4).
Report is 5 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (9d70957) and HEAD (7ebcfa4). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9d70957) HEAD (7ebcfa4)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5891       +/-   ##
===========================================
- Coverage   96.82%   51.46%   -45.37%     
===========================================
  Files         342      174      -168     
  Lines       16520     8868     -7652     
===========================================
- Hits        15996     4564    -11432     
- Misses        338     3861     +3523     
- Partials      186      443      +257     
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.81% <ø> (ø)
cassandra-3.x-v1 16.62% <ø> (ø)
cassandra-3.x-v2 1.74% <ø> (ø)
cassandra-4.x-v1 16.62% <ø> (ø)
cassandra-4.x-v2 1.74% <ø> (ø)
elasticsearch-6.x-v1 18.79% <ø> (ø)
elasticsearch-7.x-v1 18.85% <ø> (ø)
elasticsearch-8.x-v1 19.03% <ø> (ø)
elasticsearch-8.x-v2 1.80% <ø> (-0.02%) ⬇️
grpc_v1 9.47% <ø> (-0.02%) ⬇️
grpc_v2 7.14% <ø> (ø)
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.81% <ø> (ø)
memory_v2 1.81% <ø> (ø)
opensearch-1.x-v1 18.90% <ø> (+0.01%) ⬆️
opensearch-2.x-v1 18.90% <ø> (ø)
opensearch-2.x-v2 1.81% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this pull request Aug 28, 2024
…md (jaegertracing#5891)

esCleaner.py no longer exists, but README.md still has the relevant
content, so I've made some adjustments.

---------

Signed-off-by: 王然 <ranwang@alauda.io>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Co-authored-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
mahadzaryab1 pushed a commit to mahadzaryab1/jaeger that referenced this pull request Aug 31, 2024
…md (jaegertracing#5891)

esCleaner.py no longer exists, but README.md still has the relevant
content, so I've made some adjustments.

---------

Signed-off-by: 王然 <ranwang@alauda.io>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Co-authored-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG documentation storage/elasticsearch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants