Implement Telemetery struct for V1 Components Initialization

[Wise-Wizard]

Which problem is this PR solving?

This PR addresses a part of the issue #5633

Description of the changes
This is a Draft PR to achieve Observability Parity between V1 and V2 components by creating an unified telemetery container to pass observability clients to V1 components.
How was this change tested?

The changes were tested by running the following command:

make test

Checklist

• I have read CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[codecov]

Codecov Report

Attention: Patch coverage is 86.76471% with 9 lines in your changes missing coverage. Please review.

Project coverage is 96.84%. Comparing base (295293c) to head (25f8d10).

Files	Patch %	Lines
cmd/query/app/server.go	77.50%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5695      +/-   ##
==========================================
- Coverage   96.88%   96.84%   -0.05%     
==========================================
  Files         334      335       +1     
  Lines       16141    16155      +14     
==========================================
+ Hits        15639    15645       +6     
- Misses        333      340       +7     
- Partials      169      170       +1     

Flag	Coverage Δ
badger_v1	8.06% <ø> (ø)
badger_v2	1.90% <ø> (ø)
cassandra-3.x-v1	16.62% <ø> (ø)
cassandra-3.x-v2	1.82% <ø> (ø)
cassandra-4.x-v1	16.62% <ø> (ø)
cassandra-4.x-v2	1.82% <ø> (ø)
elasticsearch-6.x-v1	18.79% <ø> (-0.02%)	⬇️
elasticsearch-7.x-v1	18.86% <ø> (ø)
elasticsearch-8.x-v1	19.05% <ø> (+0.01%)	⬆️
elasticsearch-8.x-v2	1.90% <ø> (+0.01%)	⬆️
grpc_v1	9.46% <ø> (+0.01%)	⬆️
grpc_v2	7.41% <ø> (ø)
kafka	9.75% <ø> (ø)
opensearch-1.x-v1	18.91% <ø> (ø)
opensearch-2.x-v1	18.91% <ø> (+0.01%)	⬆️
opensearch-2.x-v2	1.90% <ø> (ø)
unittests	95.23% <86.76%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Wise-Wizard]

The initialization of the Telemetery Struct can't be done from the source itself, because different components have different requirements. Some mains() are passing jTracer.NoOp, whereas some aren't passing any Tracer/Metrics Factory itself.
So, the telemetery struct will have different initialization every time.
Am I right?

[yurishkuro]

lgtm, let's clean up tests / lint and merge

[Wise-Wizard]

lgtm, let's clean up tests / lint and merge

What about the problem of jTracer being separately intialized in V2 context and the only field which has to be created and passed uniquely?

[Wise-Wizard]

Also, Please review the server_Test.go file, should I keep initializing the telset in each function call, or should I create a separate function initializing the telset, because args for logger (zaptest.Logger/flagsvc.Logger) and healthcheck can be different based on the function that is calling it.

[yurishkuro]

What about the problem of jTracer being separately intialized in V2 context

I think in the current form it's not worse than before, but yes, we need to address it later by properly instructing OTEL Collector to configure the telemetry providers.

[yurishkuro]

Please review the server_Test.go file, should I keep initializing the telset in each function call, or should I create a separate function initializing the telset

create a helper function and call it from each test

[Wise-Wizard]

In the TestServerStart, the line server.Shutdown is resulting in a nil pointer deference error.
I am not able to figure out the reason for it to throw an error. It is specific to the one test case which I have commented out int server_Test.go

[yurishkuro]

In the TestServerStart, the line server.Shutdown is resulting in a nil pointer deference error.

why? If nil pointer results in a panic you get the exact line in the stacktrace.

[Wise-Wizard]

In the TestServerStart, the line server.Shutdown is resulting in a nil pointer deference error.

why? If nil pointer results in a panic you get the exact line in the stacktrace.

Yes, Line 316 in server.go is causing an Error, gRPC go routine is cauing a nil pointer deference error.

I tried adding nil checks but not able to figure out the root cause for this error.