Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new warnings from the linter upgrade #5589

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix new warnings from the linter upgrade #5589

merged 1 commit into from
Jun 12, 2024

Conversation

WaterLemons2k
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

Fix new warnings from the golangci-lint linter upgrade.

How was this change tested?

The configuration has been verified with the command golangci-lint config verify.

Checklist


These warnings came from: https://github.com/golangci/golangci-lint/blob/master/pkg/config/loader.go#L374

Resolves #5585

The configuration has been verified with the command `golangci-lint config verify`.

Signed-off-by: Shane Sun <62788816+WaterLemons2k@users.noreply.github.com>
@WaterLemons2k WaterLemons2k requested a review from a team as a code owner June 12, 2024 12:13
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (0e7aaec) to head (1a7e36a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5589      +/-   ##
==========================================
- Coverage   96.21%   96.20%   -0.02%     
==========================================
  Files         327      327              
  Lines       16006    16006              
==========================================
- Hits        15400    15398       -2     
- Misses        431      432       +1     
- Partials      175      176       +1     
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.93% <ø> (ø)
cassandra-3.x-v1 16.45% <ø> (ø)
cassandra-3.x-v2 1.85% <ø> (ø)
cassandra-4.x-v1 16.45% <ø> (ø)
cassandra-4.x-v2 1.85% <ø> (ø)
elasticsearch-7.x-v1 18.88% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v1 19.07% <ø> (ø)
elasticsearch-8.x-v2 19.09% <ø> (+0.01%) ⬆️
grpc_v1 9.48% <ø> (ø)
grpc_v2 7.53% <ø> (ø)
kafka 9.77% <ø> (ø)
opensearch-1.x-v1 18.93% <ø> (ø)
opensearch-2.x-v1 18.94% <ø> (+0.01%) ⬆️
opensearch-2.x-v2 18.93% <ø> (-0.02%) ⬇️
unittests 94.07% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jun 12, 2024
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit 0c8e025 into jaegertracing:main Jun 12, 2024
40 of 41 checks passed
@WaterLemons2k WaterLemons2k deleted the fix-warnings branch June 12, 2024 20:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address new warnings from the linter upgrade
2 participants