Fix binary path in package-deploy.sh #5561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkowall
approved these changes
Jun 11, 2024
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5561 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 327 327
Lines 16006 16006
=======================================
Hits 15398 15398
Misses 432 432
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
added a commit
that referenced
this pull request
Jun 22, 2024
## Which problem is this PR solving? - A bug was introduced in #5501 where the wrong binary path was used ## Description of the changes - Use the right path - Allow overriding `tar` command since on MacOS the `--sort` option is not supported (so I had to use `gtar` to test) ## How was this change tested? These steps succeeded locally: ``` $ make build-all-platforms $ TARCMD=gtar bash scripts/package-deploy.sh ``` Signed-off-by: Yuri Shkuro <github@ysh.us>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
tarcommand since on MacOS the--sortoption is not supported (so I had to usegtarto test)How was this change tested?
These steps succeeded locally: