Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] Change e2e jaeger-v2 binary log output to temp file #5431
[v2] Change e2e jaeger-v2 binary log output to temp file #5431
Changes from 5 commits
a8c9e41
3c47433
3222ac1
766131f
dea889c
5f6f754
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 104 in cmd/jaeger/internal/integration/e2e_integration.go
Codecov / codecov/patch
cmd/jaeger/internal/integration/e2e_integration.go#L101-L104
Check warning on line 108 in cmd/jaeger/internal/integration/e2e_integration.go
Codecov / codecov/patch
cmd/jaeger/internal/integration/e2e_integration.go#L106-L108
Check warning on line 110 in cmd/jaeger/internal/integration/e2e_integration.go
Codecov / codecov/patch
cmd/jaeger/internal/integration/e2e_integration.go#L110
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps it makes sense to configure codecov to ignore cmd/jaeger/internal/integration/