Replace security self-assesment with one from cncf/tag-security #5142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Kowall <jkowall@kowall.net>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5142 +/- ##
==========================================
- Coverage 95.65% 95.62% -0.04%
==========================================
Files 324 324
Lines 18590 18590
==========================================
- Hits 17782 17776 -6
- Misses 649 653 +4
- Partials 159 161 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
previously approved these changes
Jan 24, 2024
yurishkuro
reviewed
Jan 24, 2024
| @@ -32,7 +32,7 @@ security-artifacts: | |||
| self-assessment: | |||
| self-assessment-created: true | |||
| evidence-url: | |||
| - https://github.com/jaegertracing/jaeger/blob/main/SELF-ASSESMENT.md | |||
| - https://github.com/cncf/tag-security/blob/main/assessments/projects/jaeger/self-assessment.md | |||
There was a problem hiding this comment.
then what do we do with https://github.com/jaegertracing/jaeger/blob/main/SELF-ASSESMENT.md ?
There was a problem hiding this comment.
Good catch, just removed it.
yurishkuro
dismissed
their stale review
want to understand what happens with existing assessment
Signed-off-by: Jonah Kowall <jkowall@kowall.net>
yurishkuro
approved these changes
Jan 24, 2024
yurishkuro
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Big thank you to the security pals team on the self-assessment work they did with the help of the NYU students. The discussion happened in cncf/tag-security#1198
How was this change tested?
No need to test, just updating URL.
Checklist