Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp: Rename jaeger-v2 binary to just jaeger #4918

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Per discussion with maintainers, rename jaeger-v2 binary to just jaeger.
  • Motivation:
    • In the long run it's not going to be convenient for users to refer to jaeger-v2, projects typically don't do that
    • The name jaeger is currently unused (e.g. in Docker Hub)
    • Since we're combining all deployment units into one binary, jaeger name is quite appropriate

How was this change tested?

$ go run -tags=ui ./cmd/jaeger

grep -ri jaeger-v2 . does not find any references (except in the changelog)

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner November 3, 2023 15:16
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro closed this Nov 3, 2023
@yurishkuro yurishkuro reopened this Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
cmd/query/app/flags.go 100.00% <ø> (ø)
plugin/storage/memory/factory.go 76.31% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro merged commit 080b77f into jaegertracing:main Nov 3, 2023
40 of 63 checks passed
@yurishkuro yurishkuro deleted the rename-v2 branch November 3, 2023 19:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:exprimental Change to an experimental part of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant