TLS configuration for Admin Server #3679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3679 +/- ##
==========================================
- Coverage 96.59% 96.57% -0.02%
==========================================
Files 268 268
Lines 15717 15742 +25
==========================================
+ Hits 15182 15203 +21
- Misses 445 449 +4
Partials 90 90
Continue to review full report at Codecov.
|
yurishkuro
reviewed
May 16, 2022
yurishkuro
reviewed
May 16, 2022
yurishkuro
reviewed
May 16, 2022
yurishkuro
reviewed
May 16, 2022
| @@ -138,5 +169,6 @@ func (s *AdminServer) registerPprofHandlers() { | |||
|
|
|||
| // Close stops the HTTP server | |||
| func (s *AdminServer) Close() error { | |||
| _ = s.tlsCertWatcherCloser.Close() | |||
There was a problem hiding this comment.
nit: you can use multierr here to combine the two errors and return as one
There was a problem hiding this comment.
In collectors, we can read that
watchers actually never return errors from Close
so, I'm not sure what multierr will bring in here ?
Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
albertteoh
pushed a commit
to albertteoh/jaeger
that referenced
this pull request
Jul 13, 2022
Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com> Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes
Signed-off-by: Matthieu MOREL mmorel-35@users.noreply.github.com