fix indexDateLayout for elasticsearch dependencies #3523 #3524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NimrodAvni78
previously approved these changes
Feb 12, 2022
frzifus
reviewed
Feb 12, 2022
Signed-off-by: ilya morgenshtern <ilya.m@coralogix.com>
Codecov Report
@@ Coverage Diff @@
## main #3524 +/- ##
==========================================
- Coverage 96.53% 96.47% -0.06%
==========================================
Files 262 262
Lines 15337 15338 +1
==========================================
- Hits 14805 14798 -7
- Misses 451 456 +5
- Partials 81 84 +3
Continue to review full report at Codecov.
|
albertteoh
reviewed
Feb 12, 2022
| @@ -218,6 +218,7 @@ func createDependencyReader( | |||
| Client: client, | |||
| Logger: logger, | |||
| IndexPrefix: cfg.GetIndexPrefix(), | |||
| IndexDateLayout: cfg.GetIndexDateLayoutDependencies(), | |||
There was a problem hiding this comment.
Thanks for fixing this, I wonder if we can update the unit tests to prevent this from happening again. Maybe via a type assertion of the returned dependencystore.Reader?
There was a problem hiding this comment.
not sure I find it useful, looks like a dummy test
albertteoh
approved these changes
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.