Do not throw error on empty indices in Elasticsach rollover lookback #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com>
pavolloffay
reviewed
Nov 2, 2021
| @@ -54,16 +57,19 @@ func (a *Action) lookback(indexSet app.IndexOption) error { | |||
| finalIndices := filter.ByDate(excludedWriteIndex, getTimeReference(timeNow(), a.Unit, a.UnitCount)) | |||
|
|
|||
| if len(finalIndices) == 0 { | |||
| return fmt.Errorf("no indices to remove from alias %s", readAliasName) | |||
| a.Logger.Info(fmt.Sprintf("no indices to remove from alias %s", readAliasName)) | |||
There was a problem hiding this comment.
Please pass parameters as zap parameters only. e.g. logger.Info("Message", zap.String("param-name", "foo")
Also prefer to start the log message with a capital letter.
There was a problem hiding this comment.
Thanks @pavolloffay, updated
Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com>
Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com>
pavolloffay
previously approved these changes
Nov 2, 2021
pavolloffay
changed the title
|
@jkandasa the test is failing |
pavolloffay
changed the title
Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com>
…fix_index_rollover
Codecov Report
@@ Coverage Diff @@
## master #3369 +/- ##
==========================================
- Coverage 96.48% 96.48% -0.01%
==========================================
Files 260 260
Lines 15196 15199 +3
==========================================
+ Hits 14662 14664 +2
Misses 451 451
- Partials 83 84 +1
Continue to review full report at Codecov.
|
|
@pavolloffay I have added a fix for nil exception in unit test |
pavolloffay
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jeeva Kandasamy jkandasa@gmail.com
Which problem is this PR solving?