Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Treat input throughput data as immutable #3360

Merged
merged 5 commits into from
Oct 31, 2021

Conversation

rbroggi
Copy link
Contributor

@rbroggi rbroggi commented Oct 31, 2021

Which problem is this PR solving?

Short description of the changes

  • correct slight immutability issue discovered while enabling test shuffling

Signed-off-by: rbroggi <ro_broggi@hotmail.com>
…ritten to)

Signed-off-by: rbroggi <ro_broggi@hotmail.com>
Signed-off-by: rbroggi <ro_broggi@hotmail.com>
Signed-off-by: rbroggi <ro_broggi@hotmail.com>
Signed-off-by: rbroggi <ro_broggi@hotmail.com>
@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #3360 (37d7f34) into master (e6b1c8f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3360      +/-   ##
==========================================
+ Coverage   96.47%   96.49%   +0.01%     
==========================================
  Files         259      259              
  Lines       15166    15178      +12     
==========================================
+ Hits        14632    14646      +14     
+ Misses        451      449       -2     
  Partials       83       83              
Impacted Files Coverage Δ
...lugin/sampling/strategystore/adaptive/processor.go 100.00% <100.00%> (ø)
pkg/config/tlscfg/cert_watcher.go 94.73% <0.00%> (+2.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b1c8f...37d7f34. Read the comment docs.

@yurishkuro yurishkuro changed the title Bug immutability [bugfix] Treat input throughput data as immutable Oct 31, 2021
@yurishkuro yurishkuro enabled auto-merge (squash) October 31, 2021 20:39
@yurishkuro yurishkuro merged commit 514e72b into jaegertracing:master Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants