Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mockery to version 2 and adapt to tools-install approach #3358

Merged
merged 1 commit into from
Oct 31, 2021

Conversation

rbroggi
Copy link
Contributor

@rbroggi rbroggi commented Oct 31, 2021

Signed-off-by: rbroggi ro_broggi@hotmail.com

Which problem is this PR solving?

  • Updating mockery to v2 which is currently maintained

Short description of the changes

Mockery v2 give us 2 main benefits:

  1. it adapts to our install-tools make target approach
  2. it is well maintained

Signed-off-by: rbroggi <ro_broggi@hotmail.com>
@rbroggi rbroggi requested a review from a team as a code owner October 31, 2021 07:53
@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #3358 (fa78470) into master (7844198) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3358   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files         259      259           
  Lines       15166    15166           
=======================================
  Hits        14629    14629           
  Misses        453      453           
  Partials       84       84           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7844198...fa78470. Read the comment docs.

@yurishkuro yurishkuro merged commit b1254bd into jaegertracing:master Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants