Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jaeger chart link #3327

Closed
wants to merge 1 commit into from
Closed

Conversation

isbang
Copy link
Contributor

@isbang isbang commented Oct 17, 2021

Which problem is this PR solving?

Short description of the changes

  • I think it is more reasonable to link to Jaeger chart repository not k8s chart repository

@isbang isbang requested a review from a team as a code owner October 17, 2021 10:14
Signed-off-by: isbang <forresti3979@gmail.com>
@codecov
Copy link

codecov bot commented Oct 17, 2021

Codecov Report

Merging #3327 (0bd4152) into master (d1614eb) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3327      +/-   ##
==========================================
- Coverage   96.00%   95.98%   -0.02%     
==========================================
  Files         259      259              
  Lines       15434    15434              
==========================================
- Hits        14817    14814       -3     
- Misses        524      526       +2     
- Partials       93       94       +1     
Impacted Files Coverage Δ
cmd/query/app/server.go 94.11% <0.00%> (-1.48%) ⬇️
plugin/storage/integration/integration.go 78.88% <0.00%> (-0.40%) ⬇️
cmd/collector/app/server/zipkin.go 70.73% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1614eb...0bd4152. Read the comment docs.

@albertteoh
Copy link
Contributor

@isbang please re-create the PR from a non-master branch in your fork. Our build-pipeline tends to have issues with PRs created off master at the moment.

@isbang
Copy link
Contributor Author

isbang commented Oct 17, 2021

Ok. I will re-create this PR. Thank you!

@isbang isbang closed this Oct 17, 2021
@isbang isbang mentioned this pull request Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants