-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump OTEL version and use OTEL's vanity import path #2256
Bump OTEL version and use OTEL's vanity import path #2256
Conversation
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@@ -88,7 +88,7 @@ func configureCollector(v *viper.Viper, cfg *jaegerreceiver.Config) { | |||
} | |||
if cOpts.TLS.CertPath != "" && cOpts.TLS.KeyPath != "" { | |||
cfg.Protocols["grpc"].TLSCredentials = &receiver.TLSCredentials{ | |||
// TODO client-ca is missing in OTEL https://github.com/open-telemetry/opentelemetry-collector/issues/963 | |||
// TODO client-ca is missing in OTEL https://go.opentelemetry.io/collector/issues/963 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link in the comment is broken :(
Overall looks good to me, Just a minor comment. |
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #2256 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 219 219
Lines 10658 10658
=======================================
Hits 10248 10248
- Misses 352 353 +1
+ Partials 58 57 -1
Continue to review full report at Codecov.
|
Signed-off-by: Pavol Loffay ploffay@redhat.com