Update history package and fix failing test cases #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>
Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>
DhairyaMajmudar
force-pushed
the
update/history
branch
from
051cf59
to
8ba410c
Compare
|
cc: @yurishkuro |
yurishkuro
reviewed
Jul 5, 2024
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Dhairya Majmudar <124715224+DhairyaMajmudar@users.noreply.github.com>
|
Seems like lint checks are failing due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Updating the
historypackageReplaces #1640
Description of the changes
How was this change tested?
By running the command
yarn testpreviously 3 tests were failing due to updation of package while inspecting the failures 1 got fixed by changing import statement but the rest two were falling due to deprecatedhistory.lengthBelow is the ss of failing tests
Upon checking open issues in core repo. got these:
remix-run/history#811
remix-run/history#960
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test