Fix race condition in test, remove hard-coded namespace #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Earls <kearls@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #382 +/- ##
=======================================
Coverage 89.72% 89.72%
=======================================
Files 64 64
Lines 3094 3094
=======================================
Hits 2776 2776
Misses 216 216
Partials 102 102Continue to review full report at Codecov.
|
|
@pavolloffay @objectiser @jpkrohling Please review |
pavolloffay
reviewed
Apr 29, 2019
test/e2e/smoketest.go
Outdated
| if !strings.Contains(bodyString, "errors\":null") { | ||
| if (strings.Contains(bodyString, tStr)) { | ||
| return true, nil | ||
| } else if !strings.Contains(bodyString, "errors\":null") { |
There was a problem hiding this comment.
Keep the errors check separate from the expected spas and move it above it
There was a problem hiding this comment.
@pavolloffay Are you ok with these changes?
Signed-off-by: Kevin Earls <kearls@redhat.com>
pavolloffay
reviewed
May 3, 2019
| @@ -45,10 +45,10 @@ func SmokeTest(apiTracesEndpoint, collectorEndpoint, serviceName string, interva | |||
|
|
|||
| if !strings.Contains(bodyString, "errors\":null") { | |||
There was a problem hiding this comment.
Can be written as
if !strings.Contains(bodyString, "errors\":null") {
return false, errors.New("query service returns errors")
}
return strings.Contains(bodyString, tStr)), nilSigned-off-by: Kevin Earls <kearls@redhat.com>
pavolloffay
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Earls kearls@redhat.com
This fixes #380 where the test would fail if we did the http get before the span got flushed. I've also removed the hardcoded namespace of "default" from the es_index_cleaner_test.