Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in e2e SmokeTest #380

Closed
kevinearls opened this issue Apr 29, 2019 · 3 comments · Fixed by #382
Closed

Fix race condition in e2e SmokeTest #380

kevinearls opened this issue Apr 29, 2019 · 3 comments · Fixed by #382
Assignees

Comments

@kevinearls
Copy link
Contributor

The smoketest can fail here if the first span has not been flushed by the time the test does the http get.

https://github.com/jaegertracing/jaeger-operator/blob/master/test/e2e/smoketest.go#L46-L52

@pavolloffay
Copy link
Member

The whole block is in wait.Pool so if the spans is not there the request to query service is repeated.

@kevinearls
Copy link
Contributor Author

@pavolloffay I think the problem is that if you don't find the span you're looking for on the first try, this line returns an error, so the test terminates. https://github.com/jaegertracing/jaeger-operator/blob/master/test/e2e/smoketest.go#L50

@pavolloffay
Copy link
Member

I see that one should return nil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants